linux/zsh-syntax-highlighting
1
0
Fork 0
mirror of https://github.com/zsh-users/zsh-syntax-highlighting.git synced 2025-12-04 21:56:45 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

'main': Parameter expansions may not contain assignments.

Browse source 
In «a="b=c"; $a», the '=' sign in the expansion of $a is not active.
Therefore, prevent the expansion of $a from being considered an
assignment.  Update test expectations accordingly.

As a side effect, this prevents line 836 from firing for the cases in
these two tests, thereby fixing the double $region_highlight addition
(see log message of the previous commit).  That leaves the line 966
addition.  However, the double addition remains a latent bug (see
discussion in PR #684).
This commit is contained in:
Daniel Shahaf 2020-02-20 11:37:23 +00:00
commit aa561299f2
3 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
highlighters/main/test-data/parameter-value-contains-command-position1.zsh
View file

@ -34,5 +34,5 @@ BUFFER=$'$foobar'
expected_region_highlight=(
# Used to highlight the "ba" as 'command' because the 'ls' showed through; issues #670 and #674
'1 7 assign' # $foobar
'1 7 unknown-token' # $foobar (not an assignment)
)