From 710e80aa0dcef5e35f0a40fd0b3668cef8e9b5c9 Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Sat, 19 Jun 2021 22:53:40 +0200 Subject: [PATCH] Return build_cmd() success via a boolean For consistency with other functions in the codebase. --- app/src/sys/win/process.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/sys/win/process.c b/app/src/sys/win/process.c index f170e40d..7f5da6af 100644 --- a/app/src/sys/win/process.c +++ b/app/src/sys/win/process.c @@ -6,7 +6,7 @@ #include "util/log.h" #include "util/str_util.h" -static int +static bool build_cmd(char *cmd, size_t len, const char *const argv[]) { // Windows command-line parsing is WTF: // @@ -15,9 +15,9 @@ build_cmd(char *cmd, size_t len, const char *const argv[]) { size_t ret = xstrjoin(cmd, argv, ' ', len); if (ret >= len) { LOGE("Command too long (%" PRIsizet " chars)", len - 1); - return -1; + return false; } - return 0; + return true; } enum process_result @@ -28,7 +28,7 @@ process_execute(const char *const argv[], HANDLE *handle) { si.cb = sizeof(si); char cmd[256]; - if (build_cmd(cmd, sizeof(cmd), argv)) { + if (!build_cmd(cmd, sizeof(cmd), argv)) { *handle = NULL; return PROCESS_ERROR_GENERIC; }