linux/scrcpy
0
0
Fork 0
mirror of https://github.com/Genymobile/scrcpy.git synced 2024-09-19 05:31:21 +02:00
Code Issues Projects Releases Wiki Activity

Minimize buffer overflow on starting

Browse source 
If playback starts too early, insert silence until the buffer is filled
up to at least target_buffering before playing.
This commit is contained in:
Romain Vimont 2024-02-07 17:50:14 +01:00
parent 16f3246bcf
commit 48f8c128ef
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/src/audio_player.c
View file

@ -79,10 +79,9 @@ sc_audio_player_sdl_callback(void *userdata, uint8_t *stream, int len_int) {
bool played = atomic_load_explicit(&ap->played, memory_order_relaxed); bool played = atomic_load_explicit(&ap->played, memory_order_relaxed);
if (!played) { if (!played) {
uint32_t buffered_samples = sc_audiobuf_can_read(&ap->buf); uint32_t buffered_samples = sc_audiobuf_can_read(&ap->buf);
// Part of the buffering is handled by inserting initial silence. The // Wait until the buffer is filled up to at least target_buffering
// remaining (margin) last samples will be handled by compensation. // before playing
uint32_t margin = 30 * ap->sample_rate / 1000; // 30ms if (buffered_samples < ap->target_buffering) {
if (buffered_samples + margin < ap->target_buffering) {
LOGV("[Audio] Inserting initial buffering silence: %" PRIu32 LOGV("[Audio] Inserting initial buffering silence: %" PRIu32
" samples", count); " samples", count);
// Delay playback starting to reach the target buffering. Fill the // Delay playback starting to reach the target buffering. Fill the