From 071d459ad7d32fb6465216a0f5df7696db3adc02 Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Mon, 29 Jul 2024 19:58:40 +0200 Subject: [PATCH] Fix --no-audio By default, the audio source is initialized to SC_AUDIO_SOURCE_AUTO, and is "resolved" only if audio is enabled. But the server arguments were built assuming that the audio source was never SC_AUDIO_SOURCE_AUTO (even with audio disabled), causing a crash. Regression introduced by a10f8cd798023f858796b023cb846fa2184ad2c7. --- app/src/server.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/server.c b/app/src/server.c index 0db29183..41517f18 100644 --- a/app/src/server.c +++ b/app/src/server.c @@ -288,7 +288,9 @@ execute_server(struct sc_server *server, assert(params->video_source == SC_VIDEO_SOURCE_CAMERA); ADD_PARAM("video_source=camera"); } - if (params->audio_source != SC_AUDIO_SOURCE_OUTPUT) { + // If audio is enabled, an "auto" audio source must have been resolved + assert(params->audio_source != SC_AUDIO_SOURCE_AUTO || !params->audio); + if (params->audio_source != SC_AUDIO_SOURCE_OUTPUT && params->audio) { ADD_PARAM("audio_source=%s", sc_server_get_audio_source_name(params->audio_source)); }