Commit graph

5 commits

Author SHA1 Message Date
jiayang lai
cc0f7eee90 fix: Code review fixes for multiple Python files
Fixed the following issues:

1. gitstatus.py:
   - Fixed broad IOError exception handling to catch specific OSError/FileNotFoundError
   - Fixed unused variable warning by using _ for ignored stderr

2. proxy.py:
   - Fixed os.path.expandvars usage that doesn't expand ~, changed to os.path.expanduser
   - Fixed check_output call that was incorrectly passing a file path instead of command list
   - Fixed missing space in env variable assignment for aliases

3. update_emoji.py:
   - Fixed file handle leaks by using with statements for file operations
   - Removed unnecessary .keys() call in dict iteration

4. cheatsheet.py:
   - Fixed parse() function to handle lines without '=' character
   - Fixed inefficient list comprehension using any() instead
   - Fixed shadowing of built-in 'cheatsheet' function name

5. ssh-agent.py:
   - Modernized string formatting from .format() to f-string

6. ssh-proxy.py:
   - Fixed next() call without default value that crashes when no proxy env vars set
   - Fixed missing exit code propagation from subprocess.call

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-19 16:33:21 +08:00
Ruize Tang
53c4c4671a
fix(shell-proxy): support ssh-proxy using http proxy in cygwin (#12340) 2024-04-10 15:39:19 +02:00
septs
9fa3f46122
fix(shell-proxy): make ssh-proxy compatible with macOS (#10640) 2022-04-12 13:26:22 +02:00
Bryan Lee
eb94df6428
feat(shell-proxy): support SOCKS protocol based on URI scheme (#10069) 2021-12-29 09:42:35 +01:00
Septs
5ea25e6736
Add shell-proxy plugin (#8692) 2020-05-24 18:48:43 +02:00