Commit graph

4 commits

Author SHA1 Message Date
jiayang lai
cc0f7eee90 fix: Code review fixes for multiple Python files
Fixed the following issues:

1. gitstatus.py:
   - Fixed broad IOError exception handling to catch specific OSError/FileNotFoundError
   - Fixed unused variable warning by using _ for ignored stderr

2. proxy.py:
   - Fixed os.path.expandvars usage that doesn't expand ~, changed to os.path.expanduser
   - Fixed check_output call that was incorrectly passing a file path instead of command list
   - Fixed missing space in env variable assignment for aliases

3. update_emoji.py:
   - Fixed file handle leaks by using with statements for file operations
   - Removed unnecessary .keys() call in dict iteration

4. cheatsheet.py:
   - Fixed parse() function to handle lines without '=' character
   - Fixed inefficient list comprehension using any() instead
   - Fixed shadowing of built-in 'cheatsheet' function name

5. ssh-agent.py:
   - Modernized string formatting from .format() to f-string

6. ssh-proxy.py:
   - Fixed next() call without default value that crashes when no proxy env vars set
   - Fixed missing exit code propagation from subprocess.call

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-19 16:33:21 +08:00
Alexander Cyon
d78275fdbb
chore: fix typos (#12647) 2024-09-01 21:01:27 +02:00
George Rodrigues
e0e22d1120
chore(docs): fix some typos (#11211) 2022-10-03 17:03:53 +02:00
Léopold Mebazaa
0613232202
refactor(emoji): rewrite script w/ Python and update emojis (#8069)
Closes #8069
2021-12-28 18:28:42 +01:00