linux/ohmyzsh
1
0
Fork 0
mirror of https://github.com/ohmyzsh/ohmyzsh.git synced 2025-12-12 01:52:31 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
7,591 commits 1 branch 0 tags 148 MiB
Commit graph

142 commits

Author SHA1 Message Date
Paul Frederiksen
4bcd3b5757 fix: prevent .zshrc deletion during uninstall when no backup exists 
Fixes #13156

- Enhanced uninstall script to automatically restore .zshrc from uninstall backup
  when no original backup (.zshrc.pre-oh-my-zsh) exists
- Improved install script to create backup even when KEEP_ZSHRC=yes
- Added better user feedback and error handling
- Prevents data loss for users who installed with --keep-zshrc option

The issue occurred when users installed oh-my-zsh with KEEP_ZSHRC=yes
(keeping their existing .zshrc), which didn't create a backup. During
uninstall, their .zshrc would be deleted with no backup to restore.

Now the uninstall process:
1. Creates a timestamped backup of current .zshrc
2. Looks for original backup (.zshrc.pre-oh-my-zsh)
3. If found, restores the original
4. If not found, automatically restores from the uninstall backup
5. Provides clear feedback to the user

This ensures users never lose their .zshrc configuration during uninstall.
 2025-09-10 12:37:18 -04:00
Carlo Sala
cef64c465a
 		fix(install): ensure --unattended is respected (#13275) 
Closes #13274
 2025-08-19 12:46:13 +02:00
olwooz
51760e1d4a
 		feat(installer): add confirmation before overwriting existing .zshrc (#13086) 2025-08-16 18:29:43 +02:00
Gurram Siddarth Reddy
22ec00d1f6
 		chore(install): option case matching (#12881) 2025-03-20 20:29:33 +01:00
Carlo Sala
057f3ec67e
 		chore: replace all instances of twitter with X 
Closes #12536
 2024-07-03 08:51:20 +02:00
Ross Williams
4fca7ccb55
 		feat(tools): update supports_hyperlinks (#12258) 
Update to https://github.com/zkat/supports-hyperlinks/releases/tag/v3.0.0
 2024-03-07 09:54:43 +01:00
Marc Cornellà
b6afbbea3a
 		fix(installer): fix path logic and improve clarity on ZDOTDIR use 2023-12-01 17:03:15 +01:00
Marc Cornellà
f8bf88edca
 		chore(installer): remove words triggering false positives in antiviruses 2023-04-03 22:21:49 +02:00
Webpage-gh
7837ba6a99
 		fix(installer): don't use sudo when user is in Termux (#11591) 
Co-authored-by: Marc Cornellà <hello@mcornella.com>
 2023-03-31 07:37:01 +02:00
Marc Cornellà
6c3cf658f6 fix(installer): automatically create ZDOTDIR path if it doesn't exist 2023-02-02 08:53:44 +01:00
Marc Cornellà
5c9a3d2f4f fix(installer): don't use $ZDOTDIR in zshrc file if same as $HOME 
Fixes #11471
 2023-02-02 08:53:44 +01:00
Alex
b2313ec749 feat(installer): respect and install in $ZDOTDIR if set (#9376) 
Fixes #9001
Fixes #10479

Closes #9376

Co-authored-by: Marc Cornellà <hello@mcornella.com>
 2023-01-29 12:39:22 +01:00
Marc Cornellà
65a1e4edbe
 		fix(installer): detect newer Git for Windows version errors (#11157) 
Fixes #11157
 2022-10-14 20:31:33 +02:00
Marc Cornellà
ee4910e3b3
 		fix: show full hyperlinks in Konsole (#10964) 
Fixes #10964
 2022-10-12 10:55:02 +02:00
Marc Cornellà
f80cf12092
 		fix: fix OSC 8 hyperlink escape sequences 2022-10-12 10:49:44 +02:00
Marc Cornellà
9e967b4ecc
 		fix(installer): exit install directory on setup (#10804) 2022-03-28 16:33:03 +02:00
Marc Cornellà
4f0b680248
 		fix(installer): fix $HOME setting if getent is not found (macOS) 
Related: https://github.com/ohmyzsh/ohmyzsh/pull/10713/files#r820219899
 2022-03-07 11:41:02 +01:00
Marc Cornellà
c81804825c
 		fix(installer): fix removal of OMZ directory on failure 
When the `git init` call fails, the directory is not created,
so the rm command fails with a not found error. This change
checks whether the directory exists before deleting it.
 2022-02-25 14:06:19 +01:00
Marc Cornellà
914b6399e8 fix(installer): silence git init 2022-02-22 21:24:43 +01:00
Marc Cornellà
9b883aa417 fix(installer): set $HOME if not defined (#10680) 
Fixes #10680
 2022-02-22 21:24:43 +01:00
Marc Cornellà
46f5d38b1d
 		refactor(installer): use POSIX-standard's id -u -n to define $USER 2022-01-28 20:53:30 +01:00
Marc Cornellà
59c40eee8e
 		fix(installer): avoid git clone -c to support git v1.7.1 (#10621) 2022-01-27 18:01:27 +01:00
Marc Cornellà
788802af68
 		fix(installer): correct check for sudo in shell change logic 2022-01-24 15:56:10 +01:00
Marc Cornellà
861805b64d
 		fix(installer): define $USER if not defined 
Fixes missing $USER value in ArchLinux sh (bash)
 2022-01-24 15:42:10 +01:00
Marc Cornellà
c7221c5f25
 		style(installer): prefix formatting variables with FMT_ 2022-01-24 15:41:40 +01:00
Marc Cornellà
c63ba17525
 		refactor(installer): simplify user_can_sudo check 2022-01-11 19:53:50 +01:00
Marc Cornellà
a0a949de56
 		fix(installer): fix sudo check for users with password or without privileges 
The previous check only worked if the user could run `sudo` without typing the
password, which is almost none (I checked in Google Cloud Shell so I failed to
notice this).

This new check works whether the user has no sudo privileges, or if it has,
whether they have to type in the password or not.

It should really be easier to check if the user doesn't have privilege without
having to make them type the password.
 2022-01-11 19:13:23 +01:00
Marc Cornellà
b7a59e6d5c
 		fix(installer): run chsh with sudo if user has privileges 
This fixes the error in Google Cloud Shell, where a password prompt
appears when running `chsh` but the user (hello) does not have a
password.

If ran with `sudo`, the `chsh` command happens without a password
prompt.
 2022-01-11 16:45:36 +01:00
Marc Cornellà
fbdc078fa6
 		style: use 24bit colors in Oh My Zsh logo if supported 2022-01-09 23:11:35 +01:00
Marc Cornellà
f85087005a
 		fix(installer): fix POSIX shell syntax of previous commit 2021-12-26 23:27:49 +01:00
Marc Cornellà
ba069e7731
 		fix(installer): don't hard-code user $HOME directory on install 2021-12-26 22:40:38 +01:00
Marc Cornellà
fb12e41353
 		fix(install): fix backslash in printf when showing logo (#10422) 
Fixes #10422
 2021-11-16 19:24:32 +01:00
Kevin Burke
e86c6f5e7f
 		style: use -n flag in head and tail commands (#10391) 
Co-authored-by: Marc Cornellà <hello@mcornella.com>
 2021-11-09 09:04:10 +01:00
Marc Cornellà
57e8c959a0
 		style(installer): use rainbow logo and polish success message (#10211) 2021-09-23 18:28:34 +02:00
Marc Cornellà
098bcda691
 		feat(update): allow updating from branch set up on install 
Closes #8788

Co-authored-by: Nikolas Garofil <nikolas@garofil.be>
 2021-09-22 09:27:43 +02:00
Marc Cornellà
02d07f3e3d
 		fix: use $USERNAME guaranteed to always be defined in zsh 
Fixes #9701
 2021-03-25 12:08:00 +01:00
Léa Gris
95a06f3927
 		refactor(installer): fix static analysis warnings (#9529) 
* refactor(install.sh): fix static analysis warnings

Clear all warnings and errors raised by shellcheck.net static analysis.

- Replace non-POSIX shell use of `$OSTYPE` by POSIX compliant check on `uname -o`.
- Move variables out of`printf` format string.
- Refactor/simplify string formatters for error and underline.
- Fix expansion of arguments to a single string `$*` rather than individual elements `$@` within the error and underline formatters.

* fix(uname): non-posix -o option

* fix(install.sh): non portable which

Replaced non-portable `which zsh` by portable `command -v zsh`
 2021-03-16 00:06:06 +01:00
Marc Cornellà
eef04c62c2 fix(installer): fix error message if $ZSH exists when installing 
Also prefix all formatting functions with fmt_

Related: #9427
 2020-11-09 20:06:19 +01:00
Marc Cornellà
03b6a72576 docs: document oneline argument passing to install script 2020-08-20 11:28:10 +02:00
Adam G. Emerson
93f8c0686c
 		docs: add fetch install command for FreeBSD (#9172) 
Co-authored-by: Marc Cornellà <marc.cornella@live.com>
 2020-08-20 11:26:39 +02:00
Marc Cornellà
613045e7e5 Underline links in install and update script 2020-08-17 21:47:39 +02:00
Alex Zdanowicz
232cb19859
 		install: fix typo (#9069) 
Changing 'your' to 'you'
 2020-07-01 15:44:14 +02:00
Larson Carter
ce28ac42c8
 		Modernize install and update banners (#9045) 2020-06-28 22:06:13 +02:00
Michael Dorst
1a880fdb9b
 		installer: add option to install without replacing .zshrc (#8209) 
* Add option to install OMZ without replacing .zshrc

tools/install.sh respects REPLACE_RC environment variable
--noreplace-rc flag sets REPLACE_RC='no'

* Change REPLACE_RC=no to KEEP_ZSHRC=yes

Change --noreplace-rc to --keep-zshrc
 2020-02-25 22:42:39 +01:00
Jonathan Chang
0e57142729
 		installer: remove redundant cp command (#8668) 2020-02-24 20:39:10 +01:00
Marc Cornellà
b80b1a1e8b Actions to take after repository migration is complete (#8394) 
* Change project URL from robbyrussell to ohmyzsh org

* Update git remote to use ohmyzsh org repository
 2019-11-20 17:26:18 -08:00
Marc Cornellà
534ec60bfd Set default git-config values known to fix repository issues 
- core.autocrlf=false -> #4069
- fsck.zeroPaddedFilemode -> #4963

Fixes #4069
Fixes #4963
 2019-10-21 17:00:04 +02:00
Marc Cornellà
fd4571d1b0 installer: allow chsh to work in termux 2019-09-08 21:35:45 +02:00
Marc Cornellà
702a594df3 installer: don't rely on tput for coloring 
tput is error-prone and may not be needed, since all the formatting
codes used are standard across all types of terminals.
 2019-06-09 16:33:06 +02:00
Marc Cornellà
b944fee6ea installer: ask user about changing the shell to zsh 2019-06-03 17:18:25 +02:00