linux/ohmyzsh
1
0
Fork 0
mirror of https://github.com/ohmyzsh/ohmyzsh.git synced 2024-11-12 21:39:48 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

ssh-agent: autoload identities not already loaded (#7174)

Browse source 
With this PR the ssh-agent plugin checks the `ssh-add -l` output for the
identities added, and adds all those specified by the user that haven't been
added yet.

We also decouple the logic of starting ssh-agent from the logic of adding
identities, meaning that even if ssh-agent has been started by some other means
(like launchd) we can still ssh-add the user's identities.

Fixes #3019
Fixes #6979
This commit is contained in:
Marc Cornellà 2019-01-09 21:19:52 +01:00 committed by GitHub
parent a29950146b
commit fabee55948
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
plugins/ssh-agent/ssh-agent.plugin.zsh
View file

@ -2,20 +2,27 @@ typeset _agent_forwarding _ssh_env_cache
function _start_agent() { function _start_agent() {
local lifetime local lifetime
local -a identities
# start ssh-agent and setup environment
zstyle -s :omz:plugins:ssh-agent lifetime lifetime zstyle -s :omz:plugins:ssh-agent lifetime lifetime
# start ssh-agent and setup environment
echo starting ssh-agent...
ssh-agent -s ${lifetime:+-t} ${lifetime} | sed 's/^echo/#echo/' >! $_ssh_env_cache ssh-agent -s ${lifetime:+-t} ${lifetime} | sed 's/^echo/#echo/' >! $_ssh_env_cache
chmod 600 $_ssh_env_cache chmod 600 $_ssh_env_cache
. $_ssh_env_cache > /dev/null . $_ssh_env_cache > /dev/null
}
# load identies function _add_identities() {
local id line
local -a identities ids
zstyle -a :omz:plugins:ssh-agent identities identities zstyle -a :omz:plugins:ssh-agent identities identities
echo starting ssh-agent... # get list of loaded identities
ssh-add $HOME/.ssh/${^identities} for line in ${(f)"$(ssh-add -l)"}; do ids+=${${(z)line}[3]}; done
# add identities if not already loaded
for id in ${^identities}; do
[[ ${ids[(I)$HOME/.ssh/$id]} -le 0 ]] && ssh-add $HOME/.ssh/$id
done
} }
# Get the filename to store/lookup the environment from # Get the filename to store/lookup the environment from
@ -42,6 +49,8 @@ else
_start_agent _start_agent
fi fi
_add_identities
# tidy up after ourselves # tidy up after ourselves
unset _agent_forwarding _ssh_env_cache unset _agent_forwarding _ssh_env_cache
unfunction _start_agent unfunction _start_agent _add_identities