From aa9043f5eae6328194048b6a5c838613eade99ed Mon Sep 17 00:00:00 2001 From: Alexander Schlarb Date: Thu, 9 Aug 2018 20:47:16 +0200 Subject: [PATCH] common-aliases: Do not presume that $EDITOR (or $VISUAL for that matter) are always set --- plugins/common-aliases/common-aliases.plugin.zsh | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/plugins/common-aliases/common-aliases.plugin.zsh b/plugins/common-aliases/common-aliases.plugin.zsh index 7511f1ef2..c32f634fc 100644 --- a/plugins/common-aliases/common-aliases.plugin.zsh +++ b/plugins/common-aliases/common-aliases.plugin.zsh @@ -58,8 +58,15 @@ if is-at-least 4.2.0; then for ft in $_browser_fts; do alias -s $ft='$BROWSER'; done fi - _editor_fts=(cpp cxx cc c hh h inl asc txt TXT tex) - for ft in $_editor_fts; do alias -s $ft='$EDITOR'; done + # open editable text files in text editor + if [[ -n "$VISUAL" ]] || [[ -n "$EDITOR" ]]; then + _editor_fts=(cpp cxx cc c hh h inl asc txt TXT tex) + if [[ -n "$VISUAL" ]]; then + for ft in $_editor_fts; do alias -s $ft='$VISUAL'; done + else + for ft in $_editor_fts; do alias -s $ft='$EDITOR'; done + fi + fi # open image files in image viewer if [[ -n "$XIVIEWER" ]]; then