linux/ohmyzsh
Watch
1
0
Fork
You've already forked ohmyzsh
 0
mirror of https://github.com/ohmyzsh/ohmyzsh.git synced 2026-08-07 06:08:39 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(uninstaller): harden home path resolution

Browse source 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
marcelsafin 2026-07-11 18:45:24 +02:00
commit a02a881cc7
1 changed files with 25 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

39
tools/uninstall.sh
View file

@ -2,28 +2,39 @@
# Make sure important variables exist if not already defined # Make sure important variables exist if not already defined
# #
# $USER is defined by login(1) which is not always executed (e.g. containers)
# POSIX: https://pubs.opengroup.org/onlinepubs/009695299/utilities/id.html
USER=${USER:-$(id -u -n)}
# $HOME is defined at the time of login, but it could be unset. If it is unset, # $HOME is defined at the time of login, but it could be unset. If it is unset,
# a tilde by itself (~) will not be expanded to the current user's home directory. # a tilde by itself (~) will not be expanded to the current user's home directory.
# POSIX: https://pubs.opengroup.org/onlinepubs/009696899/basedefs/xbd_chap08.html#tag_08_03 # POSIX: https://pubs.opengroup.org/onlinepubs/009696899/basedefs/xbd_chap08.html#tag_08_03
HOME="${HOME:-$(getent passwd "$USER" 2>/dev/null | cut -d: -f6)}" current_uid=$(id -u 2>/dev/null)
# macOS does not have getent; use dscl to query the directory service current_user=$(id -u -n 2>/dev/null)
HOME="${HOME:-$(dscl . -read "/Users/$USER" NFSHomeDirectory 2>/dev/null | awk '{print $2}')}" HOME=${HOME:-}
# Last resort: tilde expansion via eval (POSIX, but carries injection risk) if [ -z "$HOME" ] && [ -n "$current_uid" ] && command -v getent >/dev/null 2>&1; then
HOME="${HOME:-$(eval "echo ~$USER" 2>/dev/null)}" HOME=$(getent passwd "$current_uid" 2>/dev/null | cut -d: -f6)
fi
if [ -z "$HOME" ]; then # macOS does not have getent; use dscl to query the directory service.
echo >&2 "Error: could not determine HOME directory" if [ -z "$HOME" ] && [ -n "$current_user" ] && command -v dscl >/dev/null 2>&1; then
exit 1 HOME=$(dscl . -read "/Users/$current_user" NFSHomeDirectory 2>/dev/null | awk '{print $2}')
fi
if [ -z "$HOME" ] && [ -n "$current_uid" ] && [ -r /etc/passwd ]; then
HOME=$(awk -F: -v uid="$current_uid" '$3 == uid { print $6; exit }' /etc/passwd)
fi fi
HOME=${HOME%"${HOME##*[!/]}"}
case "$HOME" in
""|/) echo >&2 "Error: could not determine HOME directory"; exit 1 ;;
/*) ;;
*) echo >&2 "Error: could not determine HOME directory"; exit 1 ;;
esac
zdot="${ZDOTDIR:-$HOME}" zdot="${ZDOTDIR:-$HOME}"
zdot=${zdot%"${zdot##*[!/]}"}
case "${zdot:-/}" in
/|.|..) echo >&2 "Error: refusing unsafe ZDOTDIR '$zdot'"; exit 1 ;;
esac
# Default OMZ directory (matches tools/install.sh logic) # Default OMZ directory (matches tools/install.sh logic)
if [ -n "$ZDOTDIR" ] && [ "$ZDOTDIR" != "$HOME" ]; then if [ -n "$ZDOTDIR" ] && [ "$zdot" != "$HOME" ]; then
OMZ_DIR="${ZSH:-$ZDOTDIR/ohmyzsh}" OMZ_DIR="${ZSH:-$zdot/ohmyzsh}"
else else
OMZ_DIR="${ZSH:-$HOME/.oh-my-zsh}" OMZ_DIR="${ZSH:-$HOME/.oh-my-zsh}"
fi fi