From 5f893dcd209fdad920a1450355acbd4c10faabf2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Marc=20Cornell=C3=A0?= <marc.cornella@live.com>
Date: Sat, 23 Mar 2019 20:56:55 +0100
Subject: [PATCH] aws: clean up aws_change_access_key function

---
 plugins/aws/aws.plugin.zsh | 21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/plugins/aws/aws.plugin.zsh b/plugins/aws/aws.plugin.zsh
index 7005af2d6..6de329bb8 100644
--- a/plugins/aws/aws.plugin.zsh
+++ b/plugins/aws/aws.plugin.zsh
@@ -15,18 +15,19 @@ function asp {
 }
 
 function aws_change_access_key {
-  if [[ "x$1" == "x" ]] then
-    echo "usage: $0 <profile.name>"
+  if [[ -z "$1" ]] then
+    echo "usage: $0 <profile>"
     return 1
-  else
-    echo "Insert the credentials when asked."
-    asp $1
-    aws iam create-access-key
-    aws configure --profile $1
-    echo "You can now safely delete the old access key running 'aws iam delete-access-key --access-key-id ID'"
-    echo "Your current keys are:"
-    aws iam list-access-keys
   fi
+
+  echo Insert the credentials when asked.
+  asp "$1"
+  aws iam create-access-key
+  aws configure --profile "$1"
+
+  echo You can now safely delete the old access key running \`aws iam delete-access-key --access-key-id ID\`
+  echo Your current keys are:
+  aws iam list-access-keys
 }
 
 function aws_profiles {