Revert "ssh-agent: improvements (#6309)"

This reverts commit a206271460.
This commit is contained in:
Marc Cornellà 2021-06-14 10:57:50 +02:00
parent 77087aaa8d
commit 3e7998aec3
No known key found for this signature in database
GPG key ID: 0314585E776A9C1B
2 changed files with 10 additions and 31 deletions

View file

@ -19,17 +19,9 @@ To enable **agent forwarding support** add the following to your zshrc file:
zstyle :omz:plugins:ssh-agent agent-forwarding on zstyle :omz:plugins:ssh-agent agent-forwarding on
``` ```
To **NOT load any identities on start** use the `lazy` style. ----
This is particularly usefull when combined with the AddKeysToAgent
(available from OpenSSH 7.2), since it allows to enter the password only
on first use.
```zsh To **load multiple identities** use the `identities` style, For example:
zstyle :omz:plugins:ssh-agent lazy yes
```
To **load multiple identities** use the `identities` style. This have no
effect if `lazy` is enabled.
```zsh ```zsh
zstyle :omz:plugins:ssh-agent identities id_rsa id_rsa2 id_github zstyle :omz:plugins:ssh-agent identities id_rsa id_rsa2 id_github

View file

@ -1,16 +1,4 @@
lockdir=/tmp/oh-my-zsh-ssh-agent.lock typeset _agent_forwarding _ssh_env_cache
while true; do
if mkdir "$lockdir" 2>/dev/null
then # directory did not exist, but was created successfully
trap 'rm -rf "$lockdir"' 0 # remove directory when script finishes
break # continue with script
else
sleep 0.1 # sleep for 0.2 and try again
fi
done
typeset _ssh_env_cache
function _start_agent() { function _start_agent() {
local lifetime local lifetime
@ -68,7 +56,10 @@ function _add_identities() {
# Get the filename to store/lookup the environment from # Get the filename to store/lookup the environment from
_ssh_env_cache="$HOME/.ssh/environment-$SHORT_HOST" _ssh_env_cache="$HOME/.ssh/environment-$SHORT_HOST"
if zstyle -t :omz:plugins:ssh-agent agent-forwarding && [[ -n "$SSH_AUTH_SOCK" ]]; then # test if agent-forwarding is enabled
zstyle -b :omz:plugins:ssh-agent agent-forwarding _agent_forwarding
if [[ $_agent_forwarding == "yes" && -n "$SSH_AUTH_SOCK" ]]; then
# Add a nifty symlink for screen/tmux if agent forwarding # Add a nifty symlink for screen/tmux if agent forwarding
[[ -L $SSH_AUTH_SOCK ]] || ln -sf "$SSH_AUTH_SOCK" /tmp/ssh-agent-$USERNAME-screen [[ -L $SSH_AUTH_SOCK ]] || ln -sf "$SSH_AUTH_SOCK" /tmp/ssh-agent-$USERNAME-screen
elif [[ -f "$_ssh_env_cache" ]]; then elif [[ -f "$_ssh_env_cache" ]]; then
@ -82,16 +73,12 @@ elif [[ -f "$_ssh_env_cache" ]]; then
ps $FILTER | grep ssh-agent | grep -q $SSH_AGENT_PID || { ps $FILTER | grep ssh-agent | grep -q $SSH_AGENT_PID || {
_start_agent _start_agent
} }
elif [[ -d $HOME/.ssh ]]; then else
_start_agent _start_agent
fi fi
if ! zstyle -t :omz:plugins:ssh-agent lazy; then _add_identities
_add_identities
fi
# tidy up after ourselves # tidy up after ourselves
unset _ssh_env_cache unset _agent_forwarding _ssh_env_cache
unfunction _start_agent _add_identities unfunction _start_agent _add_identities
rm -rf "$lockdir"