update: refactor and fix logic in check_for_upgrade.sh (#8939)

oh-my-zsh.sh

@@ -4,11 +4,6 @@ if [[ -z "$ZSH_CACHE_DIR" ]]; then
   ZSH_CACHE_DIR="$ZSH/cache"
 fi
 
-# Migrate .zsh-update file to $ZSH_CACHE_DIR
-if [ -f ~/.zsh-update ] && [ ! -f ${ZSH_CACHE_DIR}/.zsh-update ]; then
-    mv ~/.zsh-update ${ZSH_CACHE_DIR}/.zsh-update
-fi
-
 # Check for updates on initial load...
 if [ "$DISABLE_AUTO_UPDATE" != "true" ]; then
   env ZSH=$ZSH ZSH_CACHE_DIR=$ZSH_CACHE_DIR DISABLE_UPDATE_PROMPT=$DISABLE_UPDATE_PROMPT zsh -f $ZSH/tools/check_for_upgrade.sh

tools/check_for_upgrade.sh

@@ -1,62 +1,88 @@
-#!/usr/bin/env zsh
+# Migrate .zsh-update file to $ZSH_CACHE_DIR
+if [[ -f ~/.zsh-update && ! -f "${ZSH_CACHE_DIR}/.zsh-update" ]]; then
+    mv ~/.zsh-update "${ZSH_CACHE_DIR}/.zsh-update"
+fi
 
+# Cancel update if:
+# - the automatic update is disabled.
+# - the current user doesn't have write permissions nor owns the $ZSH directory.
+# - git is unavailable on the system.
+if [[ "$DISABLE_AUTO_UPDATE" = true ]] \
+   || [[ ! -w "$ZSH" || ! -O "$ZSH" ]] \
+   || ! command -v git &>/dev/null; then
+    return
+fi
+
+
+function current_epoch() {
     zmodload zsh/datetime
-
+    echo $(( EPOCHSECONDS / 60 / 60 / 24 ))
-function _current_epoch() {
-  echo $(( $EPOCHSECONDS / 60 / 60 / 24 ))
 }
 
-function _update_zsh_update() {
+function update_last-updated_file() {
-  echo "LAST_EPOCH=$(_current_epoch)" >! ${ZSH_CACHE_DIR}/.zsh-update
+    echo "LAST_EPOCH=$(current_epoch)" >! "${ZSH_CACHE_DIR}/.zsh-update"
 }
 
-function _upgrade_zsh() {
+function update_ohmyzsh() {
-  env ZSH=$ZSH sh $ZSH/tools/upgrade.sh
+    ZSH="$ZSH" sh "$ZSH/tools/upgrade.sh"
-  # update the zsh file
+    update_last-updated_file
-  _update_zsh_update
 }
 
-epoch_target=$UPDATE_ZSH_DAYS
+() {
-if [[ -z "$epoch_target" ]]; then
+    emulate -L zsh
-  # Default to old behavior
+
-  epoch_target=13
+    local epoch_target mtime option LAST_EPOCH
+
+    # Remove lock directory if older than a day
+    zmodload zsh/datetime
+    zmodload -F zsh/stat b:zstat
+    if mtime=$(zstat +mtime "$ZSH/log/update.lock" 2>/dev/null); then
+        if (( (mtime + 3600 * 24) < EPOCHSECONDS )); then
+            command rm -rf "$ZSH/log/update.lock"
+        fi
     fi
 
-# Cancel upgrade if the current user doesn't have write permissions for the
+    # Check for lock directory
-# oh-my-zsh directory.
+    if ! command mkdir "$ZSH/log/update.lock" 2>/dev/null; then
-[[ -w "$ZSH" ]] || return 0
+        return
-
-# Cancel upgrade if git is unavailable on the system
-whence git >/dev/null || return 0
-
-if mkdir "$ZSH/log/update.lock" 2>/dev/null; then
-  if [ -f ${ZSH_CACHE_DIR}/.zsh-update ]; then
-    . ${ZSH_CACHE_DIR}/.zsh-update
-
-    if [[ -z "$LAST_EPOCH" ]]; then
-      _update_zsh_update
-      rmdir $ZSH/log/update.lock # TODO: fix later
-      return 0
     fi
 
-    epoch_diff=$(($(_current_epoch) - $LAST_EPOCH))
+    # Remove lock directory on exit. `return 1` is important for when trapping a SIGINT:
-    if [ $epoch_diff -gt $epoch_target ]; then
+    #  The return status from the function is handled specially. If it is zero, the signal is
-      if [ "$DISABLE_UPDATE_PROMPT" = "true" ]; then
+    #  assumed to have been handled, and execution continues normally. Otherwise, the shell
-        _upgrade_zsh
+    #  will behave as interrupted except that the return status of the trap is retained.
+    trap "rm -rf '$ZSH/log/update.lock'; return 1" EXIT INT QUIT
+
+    # Create or update .zsh-update file if missing or malformed
+    if ! source "${ZSH_CACHE_DIR}/.zsh-update" 2>/dev/null || [[ -z "$LAST_EPOCH" ]]; then
+        update_last-updated_file
+        return
+    fi
+
+    # Number of days before trying to update again
+    epoch_target=${UPDATE_ZSH_DAYS:-13}
+    # Test if enough time has passed until the next update
+    if (( ( $(current_epoch) - $LAST_EPOCH ) < $epoch_target )); then
+        return
+    fi
+
+    # Ask for confirmation before updating unless disabled
+    if [[ "$DISABLE_UPDATE_PROMPT" = true ]]; then
+        update_ohmyzsh
     else
-        echo "[Oh My Zsh] Would you like to update? [Y/n]: \c"
+        # input sink to swallow all characters typed before the prompt
-        read line
+        # and add a newline if there wasn't one after characters typed
-        if [[ "$line" == Y* ]] || [[ "$line" == y* ]] || [ -z "$line" ]; then
+        while read -t -k 1 option; do true; done
-          _upgrade_zsh
+        [[ "$option" != ($'\n'|"") ]] && echo
-        else
-          _update_zsh_update
-        fi
-      fi
-    fi
-  else
-    # create the zsh file
-    _update_zsh_update
-  fi
 
-  rmdir $ZSH/log/update.lock
+        echo -n "[oh-my-zsh] Would you like to update? [Y/n] "
+        read -r -k 1 option
+        [[ "$option" != $'\n' ]] && echo
+        case "$option" in
+            [nN]) update_last-updated_file ;;
+            *) update_ohmyzsh ;;
+        esac
     fi
+}
+
+unset -f current_epoch update_last-updated_file update_ohmyzsh