From 27228d83fe403cf664c0c8626a3874ed3989d084 Mon Sep 17 00:00:00 2001 From: Michael Morgan Date: Sat, 1 Jun 2019 11:40:04 -0700 Subject: [PATCH] fasd: update `v` alias to evaluate $EDITOR lazily (#7900) For the `v` alias to work in its current state, the environment variable EDITOR must already be defined by the time `source $ZSH/oh-my-zsh.sh` happens. However, in the included zshrc template, EDITOR is set from within the "User configuration" section, which begins immediately after the above line. This means that, unless the user knows to move their `export EDITOR` statements, EDITOR will be undefined when fasd.plugin.zsh loads, and therefore the alias will have the value 'f -e ""', preventing it from functioning. With this change, `"$EDITOR"` will be evaluated each time the alias is invoked, instead of just once when the alias is created. This allows for EDITOR to be set from "User configuration" in the zshrc, and has the additional flexibility of allowing a user to specify a different EDITOR for a single session or invocation of the alias. --- plugins/fasd/fasd.plugin.zsh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/fasd/fasd.plugin.zsh b/plugins/fasd/fasd.plugin.zsh index 36a0428a7..ec2e5183a 100644 --- a/plugins/fasd/fasd.plugin.zsh +++ b/plugins/fasd/fasd.plugin.zsh @@ -6,7 +6,7 @@ if [ $commands[fasd] ]; then # check if fasd is installed source "$fasd_cache" unset fasd_cache - alias v="f -e \"$EDITOR\"" + alias v='f -e "$EDITOR"' alias o='a -e xdg-open' alias j='zz' fi