From 67b49fe21b202772ba03c504a86828d42f45493a Mon Sep 17 00:00:00 2001 From: Fini Jastrow Date: Thu, 11 Apr 2024 10:24:31 +0200 Subject: [PATCH] Improve PR template [why] I guess it would be good to explicitly state that PRs should be discussed beforehand, as the disappointment can be big if it is not even considered for pulling. Prior discussion can also clarify some technical things that otherwise would need laborious changes afterwards. Signed-off-by: Fini Jastrow --- .github/PULL_REQUEST_TEMPLATE.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 8b101419c..08e2a433d 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,7 +6,10 @@ _Please explain the changes you made here._ #### Requirements / Checklist - [ ] Read the [Contributing Guidelines](https://github.com/ryanoasis/nerd-fonts/blob/-/contributing.md) -- [ ] Verified the license of any newly added font, glyph, or glyph set +- [ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. + Issue number where discussion took place: #xxx +- [ ] If this contains a font/glyph add its origin as background info below (e.g. URL) +- [ ] Verified the license of any newly added font, glyph, or glyph set. License is: xxx #### What does this Pull Request (PR) do?