From e55bcba50e9a399d75a0ac8eb8ed65b2b56b9f6f Mon Sep 17 00:00:00 2001 From: Ayush Poddar Date: Fri, 12 Jul 2024 08:22:02 +0530 Subject: [PATCH 1/5] Remove rubygems_mfa_required setting and disable RequireMFA cop This setting was introduced automatically by the aforementioned rubocop cop,which makes it impossible to publish to rubygems automatically from a Githubaction with an API key, since one would always need the second factor. --- .rubocop.yml | 3 +++ colorls.gemspec | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.rubocop.yml b/.rubocop.yml index 607eb78..95285cd 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -113,6 +113,9 @@ Metrics/CyclomaticComplexity: Metrics/PerceivedComplexity: Max: 8 +Gemspec/RequireMFA: + Enabled: false + # TODO ----------------------------------------------------------------- Style/Documentation: diff --git a/colorls.gemspec b/colorls.gemspec index 0a7b5e4..8bf8d0a 100644 --- a/colorls.gemspec +++ b/colorls.gemspec @@ -81,5 +81,4 @@ Gem::Specification.new do |spec| spec.add_development_dependency 'rubocop-rspec', '~> 2.20.0' spec.add_development_dependency 'rubygems-tasks', '~> 0' spec.add_development_dependency 'simplecov', '~> 0.22.0' - spec.metadata['rubygems_mfa_required'] = 'true' end From c8a0401a618186b071e6b37ed354f40b76491702 Mon Sep 17 00:00:00 2001 From: Claudio Bley Date: Fri, 12 Jul 2024 08:11:48 +0200 Subject: [PATCH 2/5] Disable codecov The uploader was deprecated and is no longer working. There is a new uploader that should be used instead: https://docs.codecov.com/docs/codecov-uploader --- spec/spec_helper.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 6945b08..59e2a3b 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -6,7 +6,7 @@ SimpleCov.start do add_filter '/spec/' end -if ENV['CI'] == 'true' +if ENV['CI'] == 'never' # FIXME: migrate to new Codecov uploader / action require 'codecov' SimpleCov.formatter = SimpleCov::Formatter::Codecov end From 073964975e0e430039c9e6f97b76545b0bd5e9ee Mon Sep 17 00:00:00 2001 From: Claudio Bley Date: Fri, 12 Jul 2024 08:17:17 +0200 Subject: [PATCH 3/5] Set permissions for release drafter workflow --- .github/workflows/release-drafter.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml index 1d6c767..9202fda 100644 --- a/.github/workflows/release-drafter.yml +++ b/.github/workflows/release-drafter.yml @@ -13,9 +13,18 @@ on: # pull_request_target: # types: [opened, reopened, synchronize] +permissions: + contents: read + jobs: update_release_draft: runs-on: ubuntu-latest + permissions: + # write permission is required to create a github release + contents: write + # write permission is required for autolabeler + # otherwise, read permission is required at least + pull-requests: write steps: # Drafts your next Release notes as Pull Requests are merged into "master" - uses: release-drafter/release-drafter@v5 From 6f7dedc950a2820e6f8e775ad797056b0111908c Mon Sep 17 00:00:00 2001 From: Claudio Bley Date: Fri, 12 Jul 2024 08:18:48 +0200 Subject: [PATCH 4/5] Upgrade release-drafter to v6 --- .github/workflows/release-drafter.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/release-drafter.yml b/.github/workflows/release-drafter.yml index 9202fda..12ca158 100644 --- a/.github/workflows/release-drafter.yml +++ b/.github/workflows/release-drafter.yml @@ -27,7 +27,7 @@ jobs: pull-requests: write steps: # Drafts your next Release notes as Pull Requests are merged into "master" - - uses: release-drafter/release-drafter@v5 + - uses: release-drafter/release-drafter@v6 # (Optional) specify config name to use, relative to .github/. Default: release-drafter.yml # with: # config-name: my-config.yml From 0b7b88ca269dbc2919e68bff4850592663db011f Mon Sep 17 00:00:00 2001 From: Claudio Bley Date: Fri, 12 Jul 2024 08:38:10 +0200 Subject: [PATCH 5/5] Disable Windows CI jobs They fail with: ``` D:/a/colorls/colorls/vendor/bundle/ruby/3.0.0/gems/hpricot-0.8.6/ext/fast_xs make.exe DESTDIR\= generating fast_xs-x64-mingw32.def compiling fast_xs.c fast_xs.c: In function 'fast_xs': fast_xs.c:165:46: error: passing argument 3 of 'rb_rescue' from incompatible pointer type [-Wincompatible-pointer-types] 165 | array = rb_rescue(unpack_utf8, self, unpack_uchar, self); | ^~~~~~~~~~~~ | | | VALUE (*)(VALUE) {aka long long unsigned int (*)(long long unsigned int)} ``` --- .github/workflows/ruby.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml index c59c214..a6f0014 100644 --- a/.github/workflows/ruby.yml +++ b/.github/workflows/ruby.yml @@ -22,7 +22,11 @@ jobs: strategy: matrix: ruby-version: ['2.6', '2.7', '3.0', '3.1'] - os: [ubuntu-latest, macos-latest, windows-latest] + os: + - ubuntu-latest + - macos-latest + # FIXME: builds on Windows are broken because of hpricot + # - windows-latest steps: - uses: actions/checkout@v2